Adds new FidesPreferenceToggled event #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4631 ↗︎
Details:
Review all test suite changes for PR #4253 ↗︎ |
||||||||||||||||||||
allisonking
suggested changes
Oct 11, 2023
| @@ -68,6 +68,7 @@ Cypress.Commands.add("visitConsentDemo", (options?: FidesConfig) => { | |||
| ); | |||
| win.addEventListener("FidesUpdated", cy.stub().as("FidesUpdated")); | |||
| win.addEventListener("FidesUIShown", cy.stub().as("FidesUIShown")); | |||
| win.addEventListener("FidesUIChanged", cy.stub().as("FidesUIChanged")); | |||
There was a problem hiding this comment.
hmm this name is a little weird to me... it sounds like the UI component itself changed. I wonder if it can be something like "FidesPreferenceToggled" ? but eh, I don't feel all that strongly about it.
eastandwestwind
force-pushed
the
1121-new-fidesuichanged-event
branch
from
a4db052
to
4638567
Compare
eastandwestwind
changed the title
Co-authored-by: Allison King <[email protected]>
eastandwestwind
added a commit
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Allison King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/1121
Description Of Changes
Adds new
FidesPreferenceToggledevent to track when toggles / user prefs change without being saved.Code Changes
FidesPreferenceToggledfor both TCF and non-TCF noticesSteps to Confirm
FidesPreferenceToggledeventPre-Merge Checklist
CHANGELOG.md