Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our CMP ID #4233

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add our CMP ID #4233

merged 2 commits into from
Oct 6, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Oct 5, 2023

Closes #4232

Description Of Changes

Add our CMP ID: 407

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Oct 5, 2023

Passing run #4485 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 1b857b1 into f836401...
Project: fides Commit: f40d08dead ℹ️
Status: Passed Duration: 00:49 💡
Started: Oct 5, 2023 9:14 PM Ended: Oct 5, 2023 9:15 PM

Review all test suite changes for PR #4233 ↗︎

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f836401) 87.66% compared to head (1b857b1) 87.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4233   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files         331      331           
  Lines       20700    20700           
  Branches     2690     2690           
=======================================
  Hits        18146    18146           
  Misses       2091     2091           
  Partials      463      463           
Files Coverage Δ
src/fides/api/util/tcf/tc_model.py 96.92% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@pattisdr pattisdr merged commit ac5ea2d into main Oct 6, 2023
45 checks passed
@pattisdr pattisdr deleted the fides_4232_cmp_id branch October 6, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CMP Id
2 participants