Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR added clarifying messages to error messages presented during connector upload #4198

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Sep 29, 2023

Closes #PROD-1059

Description Of Changes

Added clarifying language to two messages within the saas_util.py file.

Code Changes

Added language to messages already present on lines 46 and 87 to help point customers to possible solutions as well as presenting the error.

Steps to Confirm

We should be able to confirm this by trying to upload a connector (which has issues like bad indentation) and verifying the message in this build contains the clarifying language.

Pre-Merge Checklist

@MarcGEthyca MarcGEthyca self-assigned this Sep 29, 2023
@cypress
Copy link

cypress bot commented Sep 29, 2023

Passing run #4545 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 25188e4 into e30c439...
Project: fides Commit: 410386255e ℹ️
Status: Passed Duration: 00:52 💡
Started: Oct 10, 2023 9:19 PM Ended: Oct 10, 2023 9:20 PM

Review all test suite changes for PR #4198 ↗︎

@MarcGEthyca MarcGEthyca marked this pull request as ready for review October 5, 2023 14:45
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e30c439) 87.72% compared to head (25188e4) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4198   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files         331      331           
  Lines       20869    20869           
  Branches     2708     2708           
=======================================
  Hits        18308    18308           
  Misses       2094     2094           
  Partials      467      467           
Files Coverage Δ
src/fides/api/util/saas_util.py 88.94% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca merged commit 2cbdb8a into main Oct 11, 2023
@MarcGEthyca MarcGEthyca deleted the PROD-1059-MG-adding-clarifying-messaging branch October 11, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants