-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR added clarifying messages to error messages presented during connector upload #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4545 ↗︎Details:
Review all test suite changes for PR #4198 ↗︎ |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4198 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 331 331
Lines 20869 20869
Branches 2708 2708
=======================================
Hits 18308 18308
Misses 2094 2094
Partials 467 467
☔ View full report in Codecov by Sentry. |
…thub.com/ethyca/fides into PROD-1059-MG-adding-clarifying-messaging
Kelsey-Ethyca
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-1059
Description Of Changes
Added clarifying language to two messages within the saas_util.py file.
Code Changes
Added language to messages already present on lines 46 and 87 to help point customers to possible solutions as well as presenting the error.
Steps to Confirm
We should be able to confirm this by trying to upload a connector (which has issues like bad indentation) and verifying the message in this build contains the clarifying language.
Pre-Merge Checklist
CHANGELOG.md