Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Braze and Domo overrides #4196

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Update for Braze and Domo overrides #4196

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a92b1ac
feat: modify if to look for key instead of policy
SteveDMurphy Sep 29, 2023
d08f76e
fix: copy same change to if for Domo override
SteveDMurphy Oct 2, 2023
a993f45
changelog
SteveDMurphy Oct 2, 2023
17fed22
Merge branch 'main' into SteveDMurphy-4179-braze-part-two
Kelsey-Ethyca Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The types of changes are:
- TCF overlay can initialize its consent preferences from a cookie [#4124](https://github.com/ethyca/fides/pull/4124)
- Various improvements to the TCF modal such as vendor storage disclosures, vendor counts, privacy policies, etc. [#4167](https://github.com/ethyca/fides/pull/4167)
- An issue where Braze could not mask an email due to formatting [#4187](https://github.com/ethyca/fides/pull/4187)
- An issue where email was not being overridden correctly for Braze and Domo [#4196](https://github.com/ethyca/fides/pull/4196)

## [2.21.0](https://github.com/ethyca/fides/compare/2.20.2...2.21.0)

Expand Down
2 changes: 1 addition & 1 deletion src/fides/api/service/saas_request/override_implementations/braze_request_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def braze_user_update(
# regardless of the masking strategy in use
all_object_fields = row_param_values["all_object_fields"]

if "user.contact.email" in policy.get_erasure_target_categories():
if "email" in all_object_fields:
privacy_request_id = row_param_values[PRIVACY_REQUEST_ID]
all_object_fields["email"] = f"{privacy_request_id}@company.com"

Expand Down
2 changes: 1 addition & 1 deletion src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def domo_user_update(
# regardless of the masking strategy in use
all_object_fields = row_param_values["all_object_fields"]

if "user.contact.email" in policy.get_erasure_target_categories():
if "email" in all_object_fields:
privacy_request_id = row_param_values[PRIVACY_REQUEST_ID]
all_object_fields["email"] = f"{privacy_request_id}@company.com"
all_object_fields["alternateEmail"] = f"{privacy_request_id}@company.com"
Expand Down