Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing system history bugs #4146

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Sep 22, 2023

Closes #4146

Description Of Changes

Fixing misc bugs

  • ingress and egress now show up in the UI as source and destination
  • The system name is displayed for source and destination changes instead of the fides_key
  • Fixed issue with System Information badge showing for data use changes
  • privacy_decralations now show up in the UI as data use

Code Changes

  • Moved helper functions for the system history feature into a helpers file

Steps to Confirm

  • Start fidesplus
  • Create a system
  • Add a data use
  • Verify an entry was created in the history table and that the change reads "added data use"
  • Click on the row to open the modal, verify that only the Data Use badge shows up
  • Create a second system and assign this new system as the source and destination for the first system
  • Verify the entry in the history table reads "added source" and "added destination"
  • Click on the row to open the modal, verify the system name is displayed for source and destination instead of the fides_key

Pre-Merge Checklist

@galvana galvana marked this pull request as ready for review September 22, 2023 22:37
@cypress
Copy link

cypress bot commented Sep 22, 2023

Passing run #4301 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d664d8b into ad640cb...
Project: fides Commit: 09fd5358fd ℹ️
Status: Passed Duration: 00:57 💡
Started: Sep 22, 2023 10:50 PM Ended: Sep 22, 2023 10:51 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana merged commit bedd008 into main Sep 26, 2023
9 checks passed
@galvana galvana deleted the PROD-1093-UX-bugs-for-system-history-UI branch September 26, 2023 18:35
@galvana galvana linked an issue Oct 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX bugs for system history UI
2 participants