Returning GVL.JSON through Experiences API

[pattisdr]

Closes https://github.com/ethyca/fidesplus/issues/1109

Description Of Changes

Returning gvl.json under GET /privacy-experience for TCF experiences with an include_gvl=True query param

Have copied file into src/fides/data - assume FE is going to remove the file of the same name on that end.

Code Changes

• Adds a function that loads the GVL into memory when it is first called, and accesses that location every time thereafter
• Adds an include_gvl query param to GET Privacy Experience

Steps to Confirm

• Get CA Experiences with include_gvl=True, assert gvl not returned
• GET FR experience with TCF enabled, but no applicable systems, assert gvl not returned
• Assert GVL is only returned when TCF contents are returned

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[cypress]

Passing run #4339 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge c6578e1 into 57493f6...
Project: fides	Commit: 1c699529b0 ℹ️
Status: Passed	Duration: 01:13 💡
Started: Sep 26, 2023 2:30 PM	Ended: Sep 26, 2023 2:31 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (57493f6) 64.94% compared to head (c6578e1) 87.50%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4143       +/-   ##
===========================================
+ Coverage   64.94%   87.50%   +22.56%     
===========================================
  Files         326      326               
  Lines       20324    20342       +18     
  Branches     2640     2643        +3     
===========================================
+ Hits        13199    17800     +4601     
+ Misses       6657     2082     -4575     
+ Partials      468      460        -8     

Files	Coverage Δ
...i/api/v1/endpoints/privacy_experience_endpoints.py	92.92% <100.00%> (+60.97%)	⬆️
src/fides/api/models/privacy_experience.py	98.53% <100.00%> (+54.41%)	⬆️
src/fides/api/schemas/privacy_experience.py	100.00% <100.00%> (+5.81%)	⬆️
src/fides/api/util/tcf_util.py	90.55% <78.57%> (+55.01%)	⬆️

... and 151 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[allisonking]

this looks good to me! I'll work on #3941 today to get the FE to start consuming this and make sure all is good, then we can remove its version of gvl.json. I can work off of this branch, and then we can merge that one with this PR? so that we don't pollute main with two GVL.json files 😄 but if that's not a concern then merging this one first would be fine too!

[pattisdr]

I can work off of this branch, and then we can merge that one with this PR?

That sounds perfect @allisonking!

[allisonking]

Oh actually, while you're here, let's use the latest GVL: https://vendor-list.consensu.org/v3/vendor-list.json (updated 9/21)

[allisonking]

Frontend piece: #4159

[adamsachs]

preemptively approving, once the FE piece gets merged in here, assuming CI passes, let's get this merged into main.

just a general note/disclaimer that the hardcoded gvl.json is a workaround until this API is moved over to fidesplus and we leverage the dynamically fetched vendor list that's maintained there!

[pattisdr]

Thank you for your updates Allison!