Removing the connector template properties #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting them during creation
Passing run #4327 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
| config = SaaSConfig(**load_config_from_string(template.config)) | ||
| authentication = config.client_config.authentication | ||
| authorization_required = ( | ||
| authentication.strategy |
There was a problem hiding this comment.
This was a bit hard for me to read because it's doing a nested comparison instead of using and, I think something like this might be a bit more readable:
In [1]: foo = None
In [2]: bar = True if foo and foo.test else False| @@ -71,6 +74,14 @@ def _load_connector_templates(self) -> None: | |||
| config_dict = load_config(config_file) | |||
| connector_type = config_dict["type"] | |||
| human_readable = config_dict["name"] | |||
| user_guide = config_dict.get("user_guide") | |||
| authentication = config_dict["client_config"].get("authentication") | |||
| authorization_required = ( | |||
There was a problem hiding this comment.
same note as below
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4128 +/- ##
==========================================
+ Coverage 87.50% 87.51% +0.01%
==========================================
Files 326 326
Lines 20324 20323 -1
Branches 2640 2640
==========================================
+ Hits 17784 17786 +2
+ Misses 2081 2078 -3
Partials 459 459
☔ View full report in Codecov by Sentry. |
ThomasLaPiana
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4123
Description Of Changes
Removing the
authorization_requiredanduser_guideproperties fromConnectorTemplate. Calculating these values on the fly required the parsing of the SaaS config YAML and caused other threads to block.Code Changes
Steps to Confirm
Salesforce Classicconnector in the System Integration tab, this connector hasauthorization_requiredanduser_guide, The page should show anAuthorize integrationbutton and have a link to external documentation.Pre-Merge Checklist
CHANGELOG.md