-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize prefetched TCF experience preferences from cookie #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4395 ↗︎
Details:
Review all test suite changes for PR #4124 ↗︎ |
allisonking
commented
Sep 21, 2023
allisonking
commented
Sep 21, 2023
allisonking
commented
Sep 21, 2023
allisonking
commented
Sep 21, 2023
de0d05f
to
2ac9e66
Compare
allisonking
commented
Sep 21, 2023
2ac9e66
to
4b452ed
Compare
6 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 👍 , main Q is around the switch from /fides.js
to /fides-js
on our test site. I want to be sure I understand that
eastandwestwind
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4046
Closes #4011
Description Of Changes
Makes prefetch work for TCF—the thing that was making this not work was that we weren't saving TCF preferences to a cookie, and so we couldn't initialize a user's preferences from a cookie (since a prefetched experience won't have a user's individual preferences).
Code Changes
Steps to Confirm
.env
file at the root of yourfides
repo (I'm actually not sure that all of these are needed, but this works!)localhost:8080/docs
and turn TCF on via the PATCH toconsent-settings
. You'll need to authorize with these creds firstlocalhost:8080
and edit one of the existing systems.analytics.reporting.campaign_insights
(which is one of the TCF data uses). Give it a legal basis of "Consent" and save.localhost:3000
and click on "Frankfurt" from the geolocation dropdown./privacy-experience
since it is being prefetched by the privacy center! But you should still see the banner pop upUnderstand audiences through statistics or combinations of data from different sources
ONPre-Merge Checklist
CHANGELOG.md