-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Center Additional Customizations #4090
Conversation
This makes the Logo it's own component and allows it to be treated as a link if a logo_url is supplied
Passing run #4175 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great, nice job Steve! left a few suggestions but they're not blocking, and are probably more on the opinion side :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some quick local testing of this:
- Edited the sample project (Cookie House) privacy center config.json as:
{
"title": "Take control of your data",
"description": "When you use our services, you’re trusting us with your information. We understand this is a big responsibility and work hard to protect your information and put you in control.",
"description_subtext": [],
"addendum": [],
"logo_path": "https://ethyca-cdn-harpocrates.s3.amazonaws.com/assets/cookiehouse_assets/logo.svg",
"logo_url": "https://ethyca.com",
"privacy_policy_url": "https://privacy.ethyca.com/",
"privacy_policy_url_text": "Privacy Policy",
"privacy_policy_visible": true,
"actions": [
{
"policy_key": "default_access_policy",
...
- Ran
nox -s "fides_env(test)"
- Opened up the Cookie House Privacy Center on http://localhost:3001/ and confirmed both the logo URL link and the Privacy Policy link:
So in other words: this works as advertised! However, the styling of the "Privacy Policy" link feels a bit out of place, I think we should try to polish that a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SteveDMurphy! I pushed some minor styling improvements to the privacy policy link and tidied my own nit, I'm happy enough with this one now 👍
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4090 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 320 320
Lines 19702 19702
Branches 2530 2530
=======================================
Hits 17220 17220
Misses 2041 2041
Partials 441 441 ☔ View full report in Codecov by Sentry. |
Thank you a ton @NevilleS 🙌🏽 |
Co-authored-by: Neville Samuell <[email protected]>
Co-authored-by: Neville Samuell <[email protected]>
This makes the Logo it's own component and allows it to be treated as a link if a logo_url is supplied
Closes #3399
Closes #4091
Description Of Changes
This addresses some functionality changes for clients to be able to:
favicon optionalready done!Code Changes
Logo
Steps to Confirm
cd clients/privacy-center/
~/config/config.json
turbo run dev
Pre-Merge Checklist
CHANGELOG.md