Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds important CSS override to display fides toggles #4075

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Sep 12, 2023

Closes #3994

Description Of Changes

This !important CSS override on fides.js toggles ensures that if customers are using a CSS lib, for example https://getuikit.com/, that the toggles aren't getting hidden.

Code Changes

  • Adds important CSS override to ensure fides toggles are always displayed

Steps to Confirm

Screenshot 2023-09-12 at 2 24 20 PM

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Sep 12, 2023

Passing run #4084 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4e9a932 into b188e56...
Project: fides Commit: b80299b3fe ℹ️
Status: Passed Duration: 01:23 💡
Started: Sep 12, 2023 7:35 PM Ended: Sep 12, 2023 7:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just one small request

clients/fides-js/src/components/fides.css Show resolved Hide resolved
@eastandwestwind eastandwestwind merged commit 7f53a75 into main Sep 12, 2023
10 checks passed
@eastandwestwind eastandwestwind deleted the 3994-fidesjs-overlay-toggles-hidden branch September 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fides.js overlay toggles are often hidden by customer-specific stylesheets
2 participants