-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case-Insensitive Privacy Experience Region Filtering #4058
Case-Insensitive Privacy Experience Region Filtering #4058
Conversation
…d allow dashes versus hyphens.
Passing run #4050 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Thank you for reviewing 😄 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4058 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 319 319
Lines 19595 19595
Branches 2512 2512
=======================================
Hits 17125 17125
Misses 2033 2033
Partials 437 437
☔ View full report in Codecov by Sentry. |
Closes #4056
Description Of Changes
Adjust region filtering on privacy experiences so it is case-insensitive and also allow dashes and underscores.
Code Changes
GET /privacy-experience
, lowercase it and turn hyphens to underscores before proceeding with querying on region/country matches.Steps to Confirm
The following should all return France experiences:
Pre-Merge Checklist
CHANGELOG.md