Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable custom fields for new data use form #4050

Merged
merged 4 commits into from
Sep 8, 2023
Merged

re-enable custom fields for new data use form #4050

merged 4 commits into from
Sep 8, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Sep 8, 2023 •
edited by pattisdr
Loading

Fixes Fidesplus issue 1080

Closes https://github.com/ethyca/fidesplus/issues/1080

Description Of Changes

Adds custom fields section to new data use form

Screenshot 2023-09-08 at 2 44 50 PM

Steps to Confirm

  • add a custom field for "system:data use"
  • view the data use form
  • save a value in the new custom field

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

@cypress
Copy link

cypress bot commented Sep 8, 2023 •
edited
Loading

Passing run #4005 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0621631 into 29c5f36...
Project: fides Commit: a4a10f9497 ℹ️
Status: Passed Duration: 01:08 💡
Started: Sep 8, 2023 8:03 PM Ended: Sep 8, 2023 8:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

allisonking
allisonking approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just need to fix up the formatting issues and should be good to go 🚀

clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx Outdated Show resolved Hide resolved
@jpople jpople merged commit 77bc381 into main Sep 8, 2023
10 checks passed
@jpople jpople deleted the jpople/data-use-custom-fields branch September 8, 2023 20:10
Kelsey-Ethyca pushed a commit that referenced this pull request Sep 11, 2023
@jpople @Kelsey-Ethyca
re-enable custom fields for new data use form (#4050)
7459d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @allisonking