Fides Cloud Configuration: DNS Record and Privacy Center URL #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4067 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
TheAndrewJackson
changed the title
allisonking
approved these changes
Sep 11, 2023
| @@ -252,6 +262,12 @@ const configureNavRoute = ({ | |||
| return undefined; | |||
| } | |||
|
|
|||
| // If the target route would require fides cloud in a non-fides-cloud environment, | |||
| // exclude it from the group. | |||
| if (route.requiresFidesCloud && !hasFidesCloud) { | |||
There was a problem hiding this comment.
can you also add a test for this? there are pretty extensive tests in nav-config.test.ts so would be nice to keep its coverage up
There was a problem hiding this comment.
yes! I'll add one now
There was a problem hiding this comment.
tests here: d3ceb56
clients/admin-ui/src/features/privacy-experience/JavaScriptTag.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4034 +/- ##
==========================================
- Coverage 87.39% 87.39% -0.01%
==========================================
Files 319 320 +1
Lines 19595 19602 +7
Branches 2512 2512
==========================================
+ Hits 17125 17131 +6
- Misses 2033 2034 +1
Partials 437 437
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes fidesplus#1064 Closes fidesplus#1077
Description Of Changes
This PR updates the admin ui to use the new fides cloud config api to aid in environment configuration.
Code Changes
Fides.gtm()Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md