Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable locations #4029

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 5, 2023

Closes https://github.com/ethyca/fidesplus/issues/1052

Description Of Changes

image
image

Code Changes

  • Add a few constants to facilitate mapping of privacy notice regions to human readable names
  • Use the new constants for the form
  • Use the new constants for the table cells
  • Update tests

Steps to Confirm

  • Run fidesplus
  • Run the admin-ui
  • Navigate to the privacy notice table. You should see the human readable names for locations
  • Edit or add a new privacy notice. In the form, when picking a location, you should also see the human readable names.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #3967 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 398d228 into 5989b5f...
Project: fides Commit: 413b133b2d ℹ️
Status: Passed Duration: 01:21 💡
Started: Sep 6, 2023 6:12 PM Ended: Sep 6, 2023 6:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 6, 2023 18:03
@allisonking allisonking merged commit bd9d607 into main Sep 11, 2023
10 checks passed
@allisonking allisonking deleted the aking/prod-1021/human-readable-iso branch September 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants