-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on client to detect new notices for prefetched experiences #4009
Rely on client to detect new notices for prefetched experiences #4009
Conversation
…f it does not exist
…otices-on-client-for-prefetch
Passing run #3875 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
…hed experience requires consent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy to follow the path of the cookie loading for any existing consent, thanks for burning through this @eastandwestwind !!
Approving knowing tests are being worked on but looks good and the videos were really helpful as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and nits, as per usual from yours truly :)
…, undo test changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment, I'm willing to negotiate as well 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, ship it!
Closes #4001
Description Of Changes
This PR removes the need for
fides_user_device_id
in pre-fetched experience. Instead, pre-fetched experience now returns no user consent. It now relies on the client cookie, if exists, to populate any existing consent for all notices.Code Changes
fides_user_device_id
query param is not passed to the fides API if it does not existSteps to Confirm
Consent Experience
section of the page is populated. This means pre-fetch worked.Pre-Merge Checklist
CHANGELOG.md