-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with unsaved changes modal #4005
Conversation
this also refactors the system info form to use the newer unsaved changes modal
Passing run #3863 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, works great! glad to finally consolidate on one approach for these unsaved forms.
we could consider closing this: #2631
I guess we don't handle reroutes yet, but I don't know if anyone ever asked for that :)
@allisonking I'll go ahead an close #2361. If anyone asks for it we can make a new ticket |
Closes #4006
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md