Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with unsaved changes modal #4005

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Aug 31, 2023

Closes #4006

Code Changes

  • Fix regression in form values that caused the unsaved changes modal to show up incorrectly
  • Refactor the system info form to use the newer more generalized unsaved changes modal

Steps to Confirm

  • run admin ui and fides server
  • create a system
  • click on data use tab
  • click back to system tab
  • click on data use tab again
  • verify that the unsaved changes modal didn't pop up

Pre-Merge Checklist

this also refactors the system info form to use the newer unsaved changes modal
@TheAndrewJackson TheAndrewJackson self-assigned this Aug 31, 2023
@cypress
Copy link

cypress bot commented Aug 31, 2023

Passing run #3863 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 09d83d6 into 2879f1c...
Project: fides Commit: aa36b2d5d3 ℹ️
Status: Passed Duration: 01:01 💡
Started: Aug 31, 2023 4:23 PM Ended: Aug 31, 2023 4:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review August 31, 2023 14:09
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works great! glad to finally consolidate on one approach for these unsaved forms.

we could consider closing this: #2631

I guess we don't handle reroutes yet, but I don't know if anyone ever asked for that :)

@TheAndrewJackson TheAndrewJackson merged commit 194005a into main Aug 31, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson/fix_unsaved_changes_modal branch August 31, 2023 16:54
@TheAndrewJackson
Copy link
Contributor Author

@allisonking I'll go ahead an close #2361. If anyone asks for it we can make a new ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsaved changes modal pops up at incorrect time
2 participants