Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF CMP stub #4000

Merged
merged 6 commits into from
Aug 30, 2023
Merged

TCF CMP stub #4000

merged 6 commits into from
Aug 30, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Aug 30, 2023

Closes N/A (an unexpected addition to #3813)

Description Of Changes

Adds a CMP stub that supports iframes. We need this for TCF certification (the chrome extension operates in an iframe). More info here: https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/blob/master/TCFv2/IAB%20Tech%20Lab%20-%20CMP%20API%20v2.md#how-can-scripts-on-a-page-determine-if-there-is-a-cmp-present

Code Changes

  • Adapts the official stub library to TypeScript and changes its exports a little bit to make it easier to import
    • I was getting errors trying to import this in rollup since it didn't have a default export
  • Calls the stub library

Steps to Confirm

  • Run fides via nox -s dev
  • Run the privacy center via FIDES_PRIVACY_CENTER__TCF_ENABLED=true turbo dev
  • Make sure tcf is enabled in /consent-settings
  • Install this chrome extension
  • Activate the chrome extension on /fides-js-demo.html
  • It should give you a handy report!

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

@allisonking allisonking changed the base branch from main to aking/3813/tcf-cmp-api August 30, 2023 18:42
@cypress
Copy link

cypress bot commented Aug 30, 2023

Passing run #3839 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 97874db into d4d7c57...
Project: fides Commit: bbd4f3a603 ℹ️
Status: Passed Duration: 01:06 💡
Started: Aug 30, 2023 8:47 PM Ended: Aug 30, 2023 8:48 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (aking/3813/tcf-cmp-api@d4d7c57). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             aking/3813/tcf-cmp-api    #4000   +/-   ##
=========================================================
  Coverage                          ?   87.53%           
=========================================================
  Files                             ?      323           
  Lines                             ?    20048           
  Branches                          ?     2597           
=========================================================
  Hits                              ?    17549           
  Misses                            ?     2052           
  Partials                          ?      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allisonking allisonking marked this pull request as ready for review August 30, 2023 20:34
@allisonking allisonking merged commit e1eaa03 into aking/3813/tcf-cmp-api Aug 30, 2023
@allisonking allisonking deleted the aking/3813/tcf-cmp-stub branch August 30, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants