-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyMSSQL #3996
Update PyMSSQL #3996
Conversation
Passing run #3819 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 318 318
Lines 19544 19544
Branches 2507 2507
=======================================
Hits 17074 17074
Misses 2034 2034
Partials 436 436
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good! both in terms of code updates and for manual testing on my M1 (ARM) machine.
per the previous PR, i verified that the following commands worked for me in a fresh pyenv:
-
pip install -e . --no-cache-dir
thenfides deploy up
-
nox -s dev
-
nox -s "fides_env(test)"
i think we're good! thanks again for staying diligent on this. i'll be very happy if we can finally put this behind us 🙏
opening a mirror PR in |
Closes #
Description Of Changes
There is a new version of
PyMSSQL
out now that should enable us to remove the myriad workarounds we hadIf this works, we'll port these changes over to
plus
as wellCode Changes
pymssql
versionSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md