Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyMSSQL #3996

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Update PyMSSQL #3996

merged 4 commits into from
Aug 30, 2023

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Aug 30, 2023

Closes #

Description Of Changes

There is a new version of PyMSSQL out now that should enable us to remove the myriad workarounds we had

If this works, we'll port these changes over to plus as well

Code Changes

  • bump pymssql version
  • remove workarounds

Steps to Confirm

  • everything works on ARM processors
  • everything works on x86 (Intel/AMD)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@ThomasLaPiana ThomasLaPiana self-assigned this Aug 30, 2023
@cypress
Copy link

cypress bot commented Aug 30, 2023

Passing run #3819 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0507c94 into ebf3263...
Project: fides Commit: 32306a92ce ℹ️
Status: Passed Duration: 01:15 💡
Started: Aug 30, 2023 8:26 AM Ended: Aug 30, 2023 8:28 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ebf3263) 87.36% compared to head (0507c94) 87.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3996   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files         318      318           
  Lines       19544    19544           
  Branches     2507     2507           
=======================================
  Hits        17074    17074           
  Misses       2034     2034           
  Partials      436      436           
Files Changed Coverage Δ
src/fides/api/main.py 87.09% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasLaPiana ThomasLaPiana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Aug 30, 2023
@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review August 30, 2023 08:52
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good! both in terms of code updates and for manual testing on my M1 (ARM) machine.

per the previous PR, i verified that the following commands worked for me in a fresh pyenv:

  • pip install -e . --no-cache-dir then fides deploy up
  • nox -s dev
  • nox -s "fides_env(test)"

i think we're good! thanks again for staying diligent on this. i'll be very happy if we can finally put this behind us 🙏

@ThomasLaPiana ThomasLaPiana merged commit ff8dab9 into main Aug 30, 2023
40 of 43 checks passed
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-update-pymssql branch August 30, 2023 17:19
@ThomasLaPiana
Copy link
Contributor Author

opening a mirror PR in plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants