Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some variables not submitting correctly in system form #3975

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 25, 2023

Description Of Changes

Fixes a bug where exempt_from_privacy_declarations, processes_personal_data and dataset_reference fields in system form weren't saving.

Code Changes

Changes some logic in transformFormValuesToSystem in src/features/system/form.ts

Steps to Confirm

  • create a new system
  • add a dataset reference
  • set "processes personal data" to false
  • save form
  • create a new system
  • set "exempt from privacy regulations" to true
  • set a reason for exemption
  • save form

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@jpople jpople marked this pull request as ready for review August 25, 2023 17:11
@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #3728 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 168c88a into e136ac6...
Project: fides Commit: f97b60303b ℹ️
Status: Passed Duration: 01:19 💡
Started: Aug 25, 2023 5:54 PM Ended: Aug 25, 2023 5:56 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jpople jpople merged commit c628efc into main Aug 25, 2023
@jpople jpople deleted the system-form-submission-fix branch August 25, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants