-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Remaining TCF Overlay Contents #3966
Merged
pattisdr
merged 8 commits into
tcf_backend_poc
from
fides_3876_remaining_tcf_overlay_contents
Aug 23, 2023
Merged
[WIP] Add Remaining TCF Overlay Contents #3966
pattisdr
merged 8 commits into
tcf_backend_poc
from
fides_3876_remaining_tcf_overlay_contents
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update ARRAY type used on System.privacy_declarations to be of the postgresql dialect. (specifically this allows us to use "overlap")
…and out, that is separate from "vendor". Saving preferences against a vendor apply to multiple systems, while saving against a fides key only applies to the particular system. - Have TCFFeature record inherit from fideslang Features. - Only embed TCF components beneath other components if they don't already exist. - Add the ability to save that consent for specific systems was served, and to also save preferences against a specific system.
…contents # Conflicts: # tests/ops/util/test_tcf_util.py
…, add docstring to privacy experience endpoint, rename confusing query param, define has_tcf_contents_variable close to where we build the base contents.
Passing run #3695 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## tcf_backend_poc #3966 +/- ##
====================================================
+ Coverage 65.06% 87.51% +22.45%
====================================================
Files 323 323
Lines 19940 19990 +50
Branches 2579 2593 +14
====================================================
+ Hits 12974 17495 +4521
+ Misses 6508 2050 -4458
+ Partials 458 445 -13
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3876
Backend for #3957
Description Of Changes
Round out the TCF Overlay. Add Features and Special Features to the overlay. Also add the new concept of "systems". You can save preferences against a "vendor" (which the system type is known) or a "system" where the vendor type is not known. If you save preferences against a vendor, that holds for all systems of that type.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md