Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Remaining TCF Overlay Contents #3966

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Aug 22, 2023

Closes #3876
Backend for #3957

Description Of Changes

Round out the TCF Overlay. Add Features and Special Features to the overlay. Also add the new concept of "systems". You can save preferences against a "vendor" (which the system type is known) or a "system" where the vendor type is not known. If you save preferences against a vendor, that holds for all systems of that type.

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

- Update ARRAY type used on System.privacy_declarations to be of the postgresql dialect.  (specifically this allows us to use "overlap")
…and out, that is separate from "vendor". Saving preferences against a vendor apply to multiple systems, while saving against a fides key only applies to the particular system.

- Have TCFFeature record inherit from fideslang Features.
- Only embed TCF components beneath other components if they don't already exist.
- Add the ability to save that consent for specific systems was served, and to also save preferences against a specific system.
…contents

# Conflicts:
#	tests/ops/util/test_tcf_util.py
…, add docstring to privacy experience endpoint, rename confusing query param, define has_tcf_contents_variable close to where we build the base contents.
@cypress
Copy link

cypress bot commented Aug 22, 2023

Passing run #3695 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 25efb1c into 2687e97...
Project: fides Commit: fdb9e4015e ℹ️
Status: Passed Duration: 00:51 💡
Started: Aug 22, 2023 6:38 PM Ended: Aug 22, 2023 6:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 94.64% and project coverage change: +22.45% 🎉

Comparison is base (2687e97) 65.06% compared to head (25efb1c) 87.51%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           tcf_backend_poc    #3966       +/-   ##
====================================================
+ Coverage            65.06%   87.51%   +22.45%     
====================================================
  Files                  323      323               
  Lines                19940    19990       +50     
  Branches              2579     2593       +14     
====================================================
+ Hits                 12974    17495     +4521     
+ Misses                6508     2050     -4458     
+ Partials               458      445       -13     
Files Changed Coverage Δ
...api/api/v1/endpoints/consent_settings_endpoints.py 100.00% <ø> (+23.80%) ⬆️
...i/api/v1/endpoints/privacy_preference_endpoints.py 99.09% <ø> (+70.13%) ⬆️
src/fides/api/models/privacy_preference.py 95.45% <82.14%> (+33.86%) ⬆️
src/fides/api/util/tcf_util.py 97.64% <98.27%> (+60.14%) ⬆️
...i/api/v1/endpoints/privacy_experience_endpoints.py 92.63% <100.00%> (+61.44%) ⬆️
src/fides/api/models/privacy_experience.py 98.53% <100.00%> (+54.90%) ⬆️
src/fides/api/models/sql_models.py 98.03% <100.00%> (ø)
src/fides/api/schemas/privacy_experience.py 100.00% <100.00%> (+5.88%) ⬆️
src/fides/api/schemas/privacy_preference.py 100.00% <100.00%> (+12.87%) ⬆️
src/fides/api/schemas/tcf.py 100.00% <100.00%> (+12.30%) ⬆️

... and 148 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pattisdr pattisdr marked this pull request as ready for review August 23, 2023 16:42
@pattisdr pattisdr merged commit bf24bf9 into tcf_backend_poc Aug 23, 2023
8 of 9 checks passed
@pattisdr pattisdr deleted the fides_3876_remaining_tcf_overlay_contents branch August 23, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant