Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing erroneous dataset fields #3923

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Removing erroneous dataset fields #3923

merged 2 commits into from
Aug 15, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 15, 2023

Closes #3921

Description Of Changes

The dataset validator changed recently to detect extra collection fields. The dataset for Vend had duplicate version fields for the sales collection

Code Changes

  • Removed erroneous fields from the Vend dataset

Steps to Confirm

  • Run nox -s "fides_env(test)"
  • Create a new system
  • Search Vend from the integration search dropdown, it should be visible

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Aug 15, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Aug 15, 2023

Passing run #3567 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7793217 into 3b7e14f...
Project: fides Commit: 38eb1462d7 ℹ️
Status: Passed Duration: 00:56 💡
Started: Aug 15, 2023 9:26 PM Ended: Aug 15, 2023 9:26 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana merged commit ef6ef3e into main Aug 15, 2023
11 of 12 checks passed
@galvana galvana deleted the 3921-fix-vend-dataset branch August 15, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vend missing from fides due to validation error
2 participants