Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated fields from form #3909

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Aug 9, 2023

Closes #3907

Note

Depends on #3901 being merged

Description Of Changes

This removes some deprecated data use fields from the taxonomy editor.

Code Changes

  • Remove deprecated fields
  • Skip old test

Steps to Confirm

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson self-assigned this Aug 9, 2023
@TheAndrewJackson TheAndrewJackson force-pushed the ajackson/3907/hide_deprecated_fields branch from 926b14c to e0ba5a9 Compare August 9, 2023 14:45
@cypress
Copy link

cypress bot commented Aug 9, 2023

Passing run #3520 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 5997635 into 58d3388...
Project: fides Commit: 8d14b1441a ℹ️
Status: Passed Duration: 01:21 💡
Started: Aug 9, 2023 3:16 PM Ended: Aug 9, 2023 3:17 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review August 9, 2023 16:24
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TheAndrewJackson TheAndrewJackson merged commit 3b7e14f into main Aug 15, 2023
10 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson/3907/hide_deprecated_fields branch August 15, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide fields in taxonomy that don't belong there post migration
2 participants