Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagging sensitive inputs as passwords to mask values during entry #3843

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 20, 2023

Closes #3842

Description Of Changes

Using a field's sensitive property to determine if an Input should behave as a password or text input.

Code Changes

  • Updated the inputs in the ConnectorParametersForm to set sensitive fields to be password inputs.

Steps to Confirm

  • Create or navigate to a system and navigate to the integration tab
  • Select an integration from the dropdown
  • Start typing in one of the password or API key fields
  • Notice the values are shown as asterisks

Pre-Merge Checklist

@galvana galvana linked an issue Jul 20, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Jul 20, 2023

Passing run #3247 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 33ae4c0 into 959d26c...
Project: fides Commit: 80fb7661ed ℹ️
Status: Passed Duration: 00:49 💡
Started: Jul 20, 2023 6:25 PM Ended: Jul 20, 2023 6:26 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana merged commit 98db649 into main Jul 20, 2023
@galvana galvana deleted the 3842-mask-sensitive-inputs-during-entry branch July 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask sensitive inputs during entry
2 participants