Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cytoscape zoom issue #3835

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 19, 2023

Closes fidesplus#832

Description Of Changes

Prevent the graph from zooming in really close when there is a small amount of systems.

less.zoom.mov

Code Changes

  • Update the graph to reduce the zoom in when there is less than 5 systems

Steps to Confirm

  • Run the admin ui turbo run dev && run fidesplus nox -s "build(fidesplus)" -- dev && nox -s "dev(fidesplus)"
  • create one system
  • go to the graph and make sure it's not super zoomed in

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jul 19, 2023

Passing run #3231 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e77c341 into 959d26c...
Project: fides Commit: 3ff2315c80 ℹ️
Status: Passed Duration: 00:47 💡
Started: Jul 19, 2023 11:40 PM Ended: Jul 19, 2023 11:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson changed the title Ajackson/fix cytoscape zoom issue fix cytoscape zoom issue Jul 19, 2023
@TheAndrewJackson TheAndrewJackson self-assigned this Jul 19, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 19, 2023 23:26
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I was finally able to test it locally and it works as expected.

@TheAndrewJackson TheAndrewJackson merged commit 6e1b4dd into main Jul 27, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson/fix_cytoscape_zoom_issue branch July 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants