-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth UI flow #3819
OAuth UI flow #3819
Conversation
Passing run #3410 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3819 +/- ##
==========================================
+ Coverage 87.19% 87.30% +0.11%
==========================================
Files 317 317
Lines 19352 19381 +29
Branches 2486 2490 +4
==========================================
+ Hits 16874 16921 +47
+ Misses 2048 2027 -21
- Partials 430 433 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE looks good to me @galvana! relatively straightforward updates, it's nice how cleanly the support has slotted in. can't comment much on the FE code though 😄
i also didn't get a chance to test manually but the video you posted looks 💥 ...that really turns up oauth integrations to the next level!
Closes #3620
Description Of Changes
Added UI support for the OAuth2 authorization code flow. We already had all the API endpoints for this workflow but we needed to be able to trigger them from the UI.
Code Changes
Authorize integration
button than needs to be clicked beforeTest integration
becomes available.referer
field to theauthenticationrequest
table to be able to redirect the user back to the system page in Fides after the integration is authorized.authorization_required
flag to each connection typeauthorized
flag toconnectionconfig
Pre-requisites
Follow the setup found here
Steps to Confirm
oauth2_authorization_code
authentication strategyAuthorize integration
Pre-Merge Checklist
CHANGELOG.md