Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unescape-safestr header to both fides-js fetch and privacy center calls #3706

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 29, 2023

Closes #3606

Description Of Changes

#3600 made the privacy-experience endpoint support a header Unescape-Safestr. This updates fides-js and privacy-center calls to include that header. (See original issue for screenshots of what this looks like without the header)

image

image

image

Code Changes

  • Privacy center addCommonHeaders now always includes Unescape-Safestr
  • Fides-js call to the privacy experience API now includes the header Unescape-Safestr

Steps to Confirm

  • Edit a privacy notice to have special characters, such as ' or &. Can also edit the privacy experience copy to have those characters as well
  • Spin up the privacy center and make sure your notices/experience reflect your ' and &s properly
  • Visit /fides-js-demo.html to also see that fides-js renders your special characters 👍

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@allisonking allisonking marked this pull request as ready for review June 29, 2023 17:52
@cypress
Copy link

cypress bot commented Jun 29, 2023

Passing run #3010 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4675b2b into c169bc5...
Project: fides Commit: 893da9056f ℹ️
Status: Passed Duration: 00:45 💡
Started: Jun 30, 2023 3:54 PM Ended: Jun 30, 2023 3:54 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@allisonking allisonking merged commit bc65cbb into main Jun 30, 2023
@allisonking allisonking deleted the aking/3606/safestr-header branch June 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include escape safestr header in fides-js and privacy center
2 participants