Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3631: add gear icon to nav #3701

Merged
merged 13 commits into from
Jun 30, 2023
Merged

3631: add gear icon to nav #3701

merged 13 commits into from
Jun 30, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jun 28, 2023

Closes #3631

Description Of Changes

  • Remove "Management" from nav bar
  • Reorder nav bar to "Home, Data map, Privacy Requests" instead of "Home, Privacy Requests, Data map"
  • Add gear icon to top-right menu that links to /user-management

Steps to Confirm

  • View navs
  • Click on gear icon in top-right

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@jpople jpople requested a review from allisonking June 28, 2023 22:25
@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #3005 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge bedaeee into f4ca8cc...
Project: fides Commit: 3d9bef0dbc ℹ️
Status: Passed Duration: 01:03 💡
Started: Jun 30, 2023 1:11 PM Ended: Jun 30, 2023 1:12 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking really solid! just a few minor things: I think you'll also need to update the cypress tests for this change. let me know if you need help with that—cypress has a bit of a learning curve, but it is well worth learning!

CHANGELOG.md Outdated Show resolved Hide resolved
clients/admin-ui/src/features/common/Header.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/common/nav/v2/NavTopBar.tsx Outdated Show resolved Hide resolved
@jpople jpople requested a review from allisonking June 30, 2023 12:51
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for making those changes!

@jpople jpople merged commit 100e118 into main Jun 30, 2023
@jpople jpople deleted the 3631-gear-icon-management branch June 30, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move management from primary nav to gear icon
2 participants