-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set sslmode
to prefer
for SSH connections
#3685
Conversation
c257fb7
to
b0c9e9d
Compare
Passing run #2919 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3685 +/- ##
==========================================
- Coverage 87.10% 87.09% -0.01%
==========================================
Files 310 310
Lines 19031 19033 +2
Branches 2437 2437
==========================================
Hits 16577 16577
- Misses 2026 2028 +2
Partials 428 428
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue and the solution make sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! changes are well-scoped to specifically apply only to RedshiftConnector
and if CONFIG.security.bastion_server_ssh_private_key
is set, so minimal impact for other use cases 👍
Closes #3680
Description Of Changes
prefer
SSLCode Changes
sslmode=prefer
for SSH connections by defaultSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md