-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Add Systems Applicable Filter to Privacy Experience List #3654
[Backend] Add Systems Applicable Filter to Privacy Experience List #3654
Conversation
… endpoint. if systems_applicable=True, then notices embedded in the response must match a data use on the system. (note that the data use hierarchy is taken into account here too). In other words, if a privacy notice data use matches a system data use, or a privacy notice data use is a parent of the system data use, this is a match, but not if a system data use is a parent of a privacy notice data use
Passing run #2956 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
==========================================
- Coverage 87.10% 87.09% -0.01%
==========================================
Files 310 310
Lines 19048 19052 +4
Branches 2438 2439 +1
==========================================
+ Hits 16592 16594 +2
- Misses 2028 2029 +1
- Partials 428 429 +1
☔ View full report in Codecov by Sentry. |
@allisonking when you have time could you take a look and add the corresponding frontend to this? There's just a new |
Since a relevant data use may have been deleted
…licable_filter # Conflicts: # CHANGELOG.md
Closes #959
Description Of Changes
If there are no systems in Fides with data uses that are mapped to privacy notices, then those notices shouldn't show up in the experiences.
Adds a
?systems_applicable
query param to Privacy Experience List (GET {{host}}/privacy-experience/?systems_applicable=True
)We have this filter on GET Privacy Notices but not on experiences themselves.
Note that the experiences themselves still show up if they exist. If you don't want to see the experience either, use the separate existing flag,
?has_notices=True
Code Changes
Steps to Confirm
GET {{host}}/privacy-experience/
andGET {{host}}/privacy-experience/?systems_applicable=True
marketing
and the system has a data use ofmarketing.advertising
- that is considered to match. The system's data use is under the scope of a privacy notice. The reverse case is not considered a match.Pre-Merge Checklist
CHANGELOG.md