Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing SafeStr character limit from 500 to 32000 #3647

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Increasing SafeStr character limit from 500 to 32000 #3647

merged 2 commits into from
Jun 21, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 21, 2023

Closes #3646

Code Changes

  • Increasing SafeStr character limit from 500 to 32000

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Description Of Changes

Increased the character limit to account for large known inputs such as CSS or PEM encoded certificates.

@galvana galvana linked an issue Jun 21, 2023 that may be closed by this pull request
Increase SafeStr character limit #3646
Closed
@galvana galvana requested a review from adamsachs June 21, 2023 20:06
NevilleS
NevilleS approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks!

adamsachs
adamsachs approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@galvana galvana merged commit 7e3eeb2 into main Jun 21, 2023
@galvana galvana deleted the 3646-increase-safestr-character-limit branch June 21, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase SafeStr character limit
3 participants
@galvana @NevilleS @adamsachs