Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with saving an edited declaration #3627

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 20, 2023

Closes #3619

Code Changes

  • Make sure to include the newly created declaration when sending a payload for editing
  • Cypress test

Steps to Confirm

  • See steps in issue

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking changed the title Fix but with saving an edited declaration Fix bug with saving an edited declaration Jun 20, 2023
@cypress
Copy link

cypress bot commented Jun 20, 2023

Passing run #2806 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9c9a673 into a361329...
Project: fides Commit: 9353d854a1 ℹ️
Status: Passed Duration: 00:43 💡
Started: Jun 20, 2023 6:51 PM Ended: Jun 20, 2023 6:52 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review June 20, 2023 19:02
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, thank you for the quick fix and for including test coverage!

@allisonking allisonking merged commit bc5b936 into main Jun 20, 2023
@allisonking allisonking deleted the aking/3619/privacy-declaration-bug branch June 20, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving one privacy declaration will sometimes delete others
2 participants