Create Consent Privacy Requests when Enforcement is System Wide Only

[pattisdr]

Closes #3618

Code Changes

• Update both endpoints that save new-style privacy preferences (through the privacy center and just against fides user device id) to only create and queue a privacy request if at least one of the privacy preferences is attached to a notice with system wide enforcement.

Steps to Confirm

• Save privacy preferences against one of the default out-of-the-box notices. Via the API directly, it is:
  PATCH {{host}}/privacy-preferences

{
   "browser_identity": {
       "ga_client_id": "UA-XXXXXXXXX",
       "ljt_readerID": "test_sovrn_id",
       "fides_user_device_id": "<uuid4 here>"
   },
   "preferences": [{
       "privacy_notice_history_id": "{{privacy_notice_history_id}}",
       "preference": "opt_out"
   }],
   "user_geography": "us_ca",
   "privacy_experience_id": "{{privacy_experience_id}}",
   "method": "button"
}

• Verify that no privacy request was created in admin UI http://localhost:3000/privacy-requests
• Update that privacy notice to have an enforcement level of system wide: via the API it is:
  PATCH {{host}}/privacy-notice

[
  {
    "id": "{{privacy_notice_id}}",
    "enforcement_level": "system_wide"
  }
]

• Save privacy preferences again - you'll have to update the privacy notice history id as it just changed
• Note that a privacy request was created because there was at least one notice that had an enforcement level of system wide
• Fetch historical preferences - you should have two records created, one should have a privacy request attached, the other should have the privacy request id as null GET {{host}}/historical-privacy-preferences

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

Description Of Changes

Only create PrivacyRequests when there is at least one notice where enforcement == "System wide".

[cypress]

Passing run #2807 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 30f58e9 into a361329...
Project: fides	Commit: 1d296050e7 ℹ️
Status: Passed	Duration: 00:47 💡
Started: Jun 20, 2023 7:04 PM	Ended: Jun 20, 2023 7:05 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a361329) 87.05% compared to head (30f58e9) 87.06%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   87.05%   87.06%           
=======================================
  Files         310      310           
  Lines       18995    18999    +4     
  Branches     2427     2429    +2     
=======================================
+ Hits        16537    16541    +4     
  Misses       2029     2029           
  Partials      429      429           

Impacted Files	Coverage Δ
...i/api/v1/endpoints/privacy_preference_endpoints.py	98.05% <100.00%> (+0.05%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pattisdr]

This is a small change that changes when we queue privacy requests for new-style consent, context here: https://ethyca.slack.com/archives/C04S7K0T2V7/p1687265733634689, if either of you have time for a quick look @adamsachs or @NevilleS.

Privacy request related fields are already optional for historical privacy preferences so there are no changes there, they can just be null.

[adamsachs]

starting review now...

[adamsachs]

this looks good to me! was able to test manually using the provided steps, thank you for spelling those out, and thank you for the comprehensive automated test coverage as well! 👍

[pattisdr]

ah thanks for reviewing @adamsachs 🙏