Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap - Erasure #3599

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Heap - Erasure #3599

merged 7 commits into from
Jul 19, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 16, 2023

Closes #1312

Code Changes

Erasure support for Heap

Steps to Confirm

  • Add/configure the connector in UI
image
  • Verify config and icon UI looks good
  • Create an Erasure DSR with the identity value

Pre-PR checklist

  • Secrets added to 1Password
    • Values for connector_params
  • Postman collection
    • All requests in the SaaS config
  • Erasure tests passing

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md
  • Icon

@cypress
Copy link

cypress bot commented Jun 16, 2023

Passing run #2787 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3caf8f5 into eb400e1...
Project: fides Commit: 63e184f239 ℹ️
Status: Passed Duration: 00:55 💡
Started: Jun 19, 2023 11:14 PM Ended: Jun 19, 2023 11:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 53.57% and project coverage change: +30.25% 🎉

Comparison is base (d6d8121) 56.76% compared to head (3caf8f5) 87.01%.

❗ Current head 3caf8f5 differs from pull request most recent head 9422bf4. Consider uploading reports for the commit 9422bf4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3599       +/-   ##
===========================================
+ Coverage   56.76%   87.01%   +30.25%     
===========================================
  Files         316      311        -5     
  Lines       19318    19030      -288     
  Branches     2483     2428       -55     
===========================================
+ Hits        10965    16559     +5594     
+ Misses       8106     2042     -6064     
- Partials      247      429      +182     
Files Changed Coverage Δ
...de_implementations/authentication_strategy_heap.py 53.57% <53.57%> (ø)

... and 221 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana merged commit b04a690 into main Jul 19, 2023
@galvana galvana deleted the heap-access-soundarya branch July 19, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heap
2 participants