Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataset dropdown from saas config #3563

Merged
merged 6 commits into from
Jun 16, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

Closes #3518

Code Changes

  • Remove dataset dropdown from saas
  • Add check to unsure dataset patching only happens for databases

Steps to Confirm

  • Run fides and admin ui
  • create a system and go to integrations tab
  • Create a saas connector and check that the dropdown isn't there
  • edit the saas connector
  • delete the saas connector
  • Create a database connector
  • Edit it and set the dataset to use the previous saas connectors (you'd never do this normally but it's helpful for this test)

Pre-Merge Checklist

Description Of Changes

@TheAndrewJackson TheAndrewJackson self-assigned this Jun 14, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review June 14, 2023 17:56
@cypress
Copy link

cypress bot commented Jun 14, 2023

Passing run #2762 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 11df3cd into 07d5355...
Project: fides Commit: c5832d2079 ℹ️
Status: Passed Duration: 00:48 💡
Started: Jun 16, 2023 8:30 PM Ended: Jun 16, 2023 8:31 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson merged commit cd254d7 into main Jun 16, 2023
@TheAndrewJackson TheAndrewJackson deleted the 3518_ajackson_remove_dataset_from_saas branch June 16, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Remove dataset field from system integrations tab for saas connectors
2 participants