Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the configure privacy request tile from the home screen #3555

Merged
merged 7 commits into from
Jun 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The types of changes are:
- Remove the `fides-js` banner from tab order when it is hidden and move the overlay components to the top of the tab order. [#3510](https://github.com/ethyca/fides/pull/3510)
- Disable connector dropdown in integration tab on save [#3552](https://github.com/ethyca/fides/pull/3552)
- Handles an edge case for non-existent identities with the Kustomer API [#3513](https://github.com/ethyca/fides/pull/3513)
- remove the configure privacy request tile from the home screen [#3555](https://github.com/ethyca/fides/pull/3555)

### Developer Experience

Expand Down
1 change: 0 additions & 1 deletion clients/admin-ui/cypress/e2e/home.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const ALL_TILES = [
"View data map",
"Add systems",
"View systems",
"Configure privacy requests",
"Review privacy requests",
];

Expand Down
18 changes: 2 additions & 16 deletions clients/admin-ui/src/home/constants.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {
ADD_SYSTEMS_ROUTE,
DATAMAP_ROUTE,
DATASTORE_CONNECTION_ROUTE,
PRIVACY_REQUESTS_ROUTE,
SYSTEM_ROUTE,
} from "~/features/common/nav/v2/routes";
Expand All @@ -15,9 +14,8 @@ import { ModuleCardConfig } from "./types";
export enum ModuleCardKeys {
ADD_SYSTEMS = 1,
VIEW_SYSTEMS = 2,
CONFIGURE_PRIVACY_REQUESTS = 3,
REVIEW_PRIVACY_REQUESTS = 4,
VIEW_MAP = 5,
REVIEW_PRIVACY_REQUESTS = 3,
VIEW_MAP = 4,
}

export const MODULE_CARD_ITEMS: ModuleCardConfig[] = [
Expand Down Expand Up @@ -57,18 +55,6 @@ export const MODULE_CARD_ITEMS: ModuleCardConfig[] = [
scopes: [ScopeRegistryEnum.SYSTEM_READ],
requiresSystems: true,
},
{
color: "teal",
description:
"Connect your systems and configure privacy request processing for DSRs (access and erasure).",
href: `${DATASTORE_CONNECTION_ROUTE}/new?step=1`,
key: ModuleCardKeys.CONFIGURE_PRIVACY_REQUESTS,
name: "Configure privacy requests",
sortOrder: 3,
title: "PR",
scopes: [ScopeRegistryEnum.CONNECTION_CREATE_OR_UPDATE],
},

{
color: "pink",
description:
Expand Down
13 changes: 1 addition & 12 deletions clients/admin-ui/src/home/tile-config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,6 @@ describe("configureTiles", () => {
expect(tiles.map((t) => t.name)).toEqual(["Add systems"]);
});

it("conditionally shows configure privacy requests", () => {
const tiles = configureTiles({
config: MODULE_CARD_ITEMS,
userScopes: [ScopeRegistryEnum.CONNECTION_CREATE_OR_UPDATE],
});
expect(tiles.map((t) => t.name)).toEqual(["Configure privacy requests"]);
});

it("conditionally shows view datamap", () => {
const tiles = configureTiles({
config: MODULE_CARD_ITEMS,
Expand All @@ -93,10 +85,7 @@ describe("configureTiles", () => {
ScopeRegistryEnum.CONNECTION_CREATE_OR_UPDATE,
],
});
expect(tiles.map((t) => t.name)).toEqual([
"Configure privacy requests",
"Review privacy requests",
]);
expect(tiles.map((t) => t.name)).toEqual(["Review privacy requests"]);
});
});
});
3 changes: 1 addition & 2 deletions clients/cypress-e2e/cypress/e2e/smoke_test.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ describe("Smoke test", () => {

cy.visit(ADMIN_UI_URL);
cy.login();
cy.get("div").contains("Configure privacy requests").click();
Kelsey-Ethyca marked this conversation as resolved.
Show resolved Hide resolved
cy.wait("@getConnections");
cy.get("a").contains("Privacy requests").click();
cy.get("a").contains("Connection manager").click();
cy.wait("@getConnectionType");
cy.getByTestId("connection-grid-item-MongoDB Connector").within(() => {
Expand Down