Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide custom fields section when there are no custom fields created #3554

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Jun 13, 2023

Closes #3545

Code Changes

Updated custom fields list to check a field is created before showing

Steps to Confirm

  • verify no custom fields created
  • verify the custom list section does not show on the system information or data use tabs
  • create a custom field for both system and system: data use
  • verify the custom list section does show on the system information or data use tabs with the respective fields you created

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jun 13, 2023

Passing run #2673 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a4bc012 into c42a0ac...
Project: fides Commit: 530f63b613 ℹ️
Status: Passed Duration: 00:46 💡
Started: Jun 14, 2023 12:14 AM Ended: Jun 14, 2023 12:15 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! ⭐

@Kelsey-Ethyca Kelsey-Ethyca merged commit 5724613 into main Jun 14, 2023
@Kelsey-Ethyca Kelsey-Ethyca deleted the kt-3545-hide-custom-fields branch June 14, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide custom field section in system portal and data use when there are no fields
2 participants