Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove form validation to allow both email & phone inputs for consent requests #3529

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Remove form validation to allow both email & phone inputs for consent requests #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501022e
Allow multiple identity inputs for consent requests
NevilleS Jun 11, 2023
8c4c147
Update CHANGELOG
NevilleS Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ The types of changes are:
- Update privacy centre email and phone validation to allow for both to be blank [#3432](https://github.com/ethyca/fides/pull/3432)
- Moved connection configuration into the system portal [#3407](https://github.com/ethyca/fides/pull/3407)
- Update `fideslang` to `1.4.1` to allow arbitrary nested metadata on `System`s and `Dataset`s `meta` property [#3463](https://github.com/ethyca/fides/pull/3463)
- Remove form validation to allow both email & phone inputs for consent requests [#3529](https://github.com/ethyca/fides/pull/3529)

### Developer Experience

Expand Down
6 changes: 0 additions & 6 deletions clients/privacy-center/components/modals/consent-request-modal/ConsentRequestForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ const ConsentRequestForm: React.FC<ConsentRequestFormProps> = ({
onBlur={handleBlur}
value={values.email}
isInvalid={touched.email && Boolean(errors.email)}
isDisabled={Boolean(
typeof values.phone !== "undefined" && values.phone
)}
/>
<FormErrorMessage>{errors.email}</FormErrorMessage>
</FormControl>
Expand All @@ -252,9 +249,6 @@ const ConsentRequestForm: React.FC<ConsentRequestFormProps> = ({
id="phone"
isInvalid={touched.phone && Boolean(errors.phone)}
isRequired={identityInputs.phone === "required"}
isDisabled={Boolean(
typeof values.email !== "undefined" && values.email
)}
>
<FormLabel fontSize="sm">Phone</FormLabel>
<PhoneInput
Expand Down