Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize CLI Command files #3491

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jun 7, 2023

Closes #3244

Code Changes

  • each command file should be for a single command group

Steps to Confirm

  • automated tests pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

This is an update that had been bothering me, as I always forgot where CLI commands were....should be more logical and easy to find now

@ThomasLaPiana ThomasLaPiana self-assigned this Jun 7, 2023
@cypress
Copy link

cypress bot commented Jun 7, 2023

Passing run #2535 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c57a5f7 into 29b3f6c...
Project: fides Commit: 95da6b4ab9 ℹ️
Status: Passed Duration: 00:59 💡
Started: Jun 7, 2023 7:35 PM Ended: Jun 7, 2023 7:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 88.65% and project coverage change: -0.01 ⚠️

Comparison is base (29b3f6c) 87.16% compared to head (c57a5f7) 87.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3491      +/-   ##
==========================================
- Coverage   87.16%   87.15%   -0.01%     
==========================================
  Files         312      311       -1     
  Lines       18806    18800       -6     
  Branches     2395     2395              
==========================================
- Hits        16392    16386       -6     
  Misses       1991     1991              
  Partials      423      423              
Impacted Files Coverage Δ
src/fides/cli/commands/deploy.py 90.90% <ø> (ø)
src/fides/cli/commands/ungrouped.py 88.48% <88.48%> (ø)
src/fides/cli/__init__.py 92.30% <100.00%> (-0.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review June 7, 2023 20:23
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a couple of nits on the docstrings for the files

@ThomasLaPiana ThomasLaPiana merged commit e9f3ed6 into main Jun 8, 2023
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-reorganize-command-files branch June 8, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize CLI code
2 participants