Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3471 support prerelease and rc image tags in dockerhub #3474

Merged

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Jun 6, 2023

Closes #3471

Code Changes

  • updates to nox session to push constant :prerelease and :rc images to docker, when requested
  • updates to GH workflow to invoke the above when appropriate, i.e. when alpha, beta or rc git tags are pushed

Steps to Confirm

  • can test by pushing some tags on this branch. an alpha tag would be appropriate, we could also do a bogus rc tag just for testing
    • this worked reasonably well - there was a hiccup (copy and paste error) that made the alpha tag actually push the rc image (oops), but this confirmed the basics that needed to be confirmed

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs linked an issue Jun 6, 2023 that may be closed by this pull request
noxfiles/docker_nox.py Outdated Show resolved Hide resolved
@adamsachs adamsachs force-pushed the 3471-support-prerelease-and-rc-image-tags-in-dockerhub branch from b8f7519 to 3c0705e Compare June 6, 2023 15:42
@adamsachs adamsachs force-pushed the 3471-support-prerelease-and-rc-image-tags-in-dockerhub branch from 3c0705e to 7fe126b Compare June 6, 2023 15:43
@cypress
Copy link

cypress bot commented Jun 6, 2023

Passing run #2479 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7a4fcd9 into 007a673...
Project: fides Commit: d532fdc9b2 ℹ️
Status: Passed Duration: 00:47 💡
Started: Jun 6, 2023 7:19 PM Ended: Jun 6, 2023 7:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1b1abbb) 87.12% compared to head (7a4fcd9) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3474   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         312      312           
  Lines       18757    18757           
  Branches     2389     2389           
=======================================
  Hits        16342    16342           
  Misses       1991     1991           
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThomasLaPiana
Copy link
Contributor

@adamsachs this looks pretty much ready to me! Great changes here, I made a few contributions too but didn't change any functionality

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review June 6, 2023 18:18
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great functionality extensions and refactors!

@adamsachs adamsachs merged commit d638d66 into main Jun 6, 2023
@adamsachs adamsachs deleted the 3471-support-prerelease-and-rc-image-tags-in-dockerhub branch June 6, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support :prerelease and :rc image tags in dockerhub
2 participants