Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Psycopg2-binary version #3473

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jun 6, 2023

Closes #3453

Code Changes

  • bump psycopg2-binary

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@ThomasLaPiana ThomasLaPiana self-assigned this Jun 6, 2023
@cypress
Copy link

cypress bot commented Jun 6, 2023

Passing run #2450 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8941440 into 1b1abbb...
Project: fides Commit: 3701d5a3c4 ℹ️
Status: Passed Duration: 00:59 💡
Started: Jun 6, 2023 3:32 PM Ended: Jun 6, 2023 3:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1b1abbb) 87.12% compared to head (8941440) 87.11%.

❗ Current head 8941440 differs from pull request most recent head 96a601b. Consider uploading reports for the commit 96a601b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3473      +/-   ##
==========================================
- Coverage   87.12%   87.11%   -0.01%     
==========================================
  Files         312      312              
  Lines       18757    18757              
  Branches     2389     2389              
==========================================
- Hits        16342    16341       -1     
- Misses       1991     1992       +1     
  Partials      424      424              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review June 6, 2023 17:22
@ThomasLaPiana
Copy link
Contributor Author

above failure was due to job timeout

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming CI passes

@ThomasLaPiana ThomasLaPiana merged commit 485d62f into main Jun 6, 2023
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-update-psycopg2-binary branch June 6, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to psycopg2-binary==2.9.6
2 participants