-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Snowflake Sqlalchemy warning on CLI usage #3434
Conversation
Passing run #2338 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3434 +/- ##
=======================================
Coverage 87.13% 87.14%
=======================================
Files 312 312
Lines 18666 18668 +2
Branches 2379 2379
=======================================
+ Hits 16265 16268 +3
+ Misses 1981 1980 -1
Partials 420 420
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just noticing this again too, thanks for sorting it out! Dependency puzzles are tough
Closes #3433
Code Changes
Steps to Confirm
fides parse
locally - note there is no warning__init__.py
file and change it tomodule="something"
fides parse
again and note that the warning comes backPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Quick fix here, suppressing the warning as specifically as possible so that we can still see other warnings come through.
We've been out-of-range for this requirement for a long time but it doesn't seem to matter, it just started showing up in the CLI though which means we probably moved some imports around
New
Old