Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snowflake Sqlalchemy warning on CLI usage #3434

Merged
merged 10 commits into from
Jun 2, 2023

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jun 2, 2023

Closes #3433

Code Changes

  • add warning suppression to the CLI init

Steps to Confirm

  • install and run fides parse locally - note there is no warning
  • edit the __init__.py file and change it to module="something"
  • run fides parse again and note that the warning comes back

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Description Of Changes

Quick fix here, suppressing the warning as specifically as possible so that we can still see other warnings come through.

We've been out-of-range for this requirement for a long time but it doesn't seem to matter, it just started showing up in the CLI though which means we probably moved some imports around

New

image

Old

image

@ThomasLaPiana ThomasLaPiana changed the title Pin PyArrow Fix Snowflake Sqlalchemy warning on CLI usage Jun 2, 2023
@ThomasLaPiana ThomasLaPiana self-assigned this Jun 2, 2023
@cypress
Copy link

cypress bot commented Jun 2, 2023

Passing run #2338 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge db7c946 into 19268c8...
Project: fides Commit: 26d2ec56a2 ℹ️
Status: Passed Duration: 00:45 💡
Started: Jun 2, 2023 7:11 AM Ended: Jun 2, 2023 7:11 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (19268c8) 87.13% compared to head (db7c946) 87.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3434   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files         312      312           
  Lines       18666    18668    +2     
  Branches     2379     2379           
=======================================
+ Hits        16265    16268    +3     
+ Misses       1981     1980    -1     
  Partials      420      420           
Impacted Files Coverage Δ
src/fides/cli/__init__.py 92.45% <100.00%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review June 2, 2023 06:47
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just noticing this again too, thanks for sorting it out! Dependency puzzles are tough

@ThomasLaPiana ThomasLaPiana merged commit c392ee4 into main Jun 2, 2023
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-pin-pyarrow branch June 2, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Snowflake UserWarning
2 participants