Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky system-plus cypress test #3408

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 31, 2023

Closes N/A

Code Changes

  • The call to update custom fields actually happens twice, one for each custom field that is being used. We were only intercepting one of the calls, and it wasn't consistent which call was intercepted, resulting in flaky failures. Now we intercept both calls and check both payloads.

Steps to Confirm

  • CI passes, cypress passes locally

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking marked this pull request as ready for review May 31, 2023 15:04
@cypress
Copy link

cypress bot commented May 31, 2023

Passing run #2271 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 26494c3 into 72df047...
Project: fides Commit: fe02d9f94a ℹ️
Status: Passed Duration: 00:47 💡
Started: May 31, 2023 3:19 PM Ended: May 31, 2023 3:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@eastandwestwind eastandwestwind merged commit e68da2a into main May 31, 2023
@eastandwestwind eastandwestwind deleted the aking/fix-flaky-cypress-test branch May 31, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants