-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional SSH Support for DSR Processing #3374
Conversation
This is really just an interim state to house a single bastion host to get something out more quickly
Passing run #2686 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
==========================================
- Coverage 87.17% 87.01% -0.16%
==========================================
Files 311 311
Lines 18802 18863 +61
Branches 2395 2402 +7
==========================================
+ Hits 16390 16414 +24
- Misses 1990 2025 +35
- Partials 422 424 +2
☔ View full report in Codecov by Sentry. |
I was originally intending on implementing this and using more of the `SQLConnector` Class but it turned out to be more trouble than it was worth without implementing more of the ssh set variable across other db connectors. As this will likely change again in the near future it made sense to keep this more isolated and leave the duplicate code found in the overridden `create_client` method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to add test infrastructure, have it added to secrets, then write tests and docs
src/fides/api/schemas/connection_configuration/connection_secrets_postgres.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @SteveDMurphy — would be good to get a follow-up ticket in for some more thorough testing
Manual testing looks good and added #3562 for the testing follow on - thanks @seanpreston and @RobertKeyser !! Will merge once checks complete |
Co-authored-by: Sean Preston <[email protected]>
Closes #3329
Code Changes
Look at the prospect of having thegenerate
andclassify
commands use the SSH tunnel in this first iterationSteps to Confirm
nox -s dev -- shell
fides user login && fides push
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is currently set up to only support a single bastion host in order to get moving more quickly. In a follow on change, we will likely create an SSH connection config type to support multiple ssh requirements.