Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow experience flag to be toggled #3364

Merged
merged 3 commits into from
May 30, 2023
Merged

Allow experience flag to be toggled #3364

merged 3 commits into from
May 30, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 24, 2023 •
edited
Loading

Closes N/A

Code Changes

  • Enable privacy experience flag to be user modifiable

Steps to Confirm

  • Run the app and check out the toggle!

Pre-Merge Checklist

Description Of Changes

image

@allisonking allisonking marked this pull request as ready for review May 24, 2023 14:53
@cypress
Copy link

cypress bot commented May 24, 2023 •
edited
Loading

Passing run #2239 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e5aca14 into 8d424d3...
Project: fides Commit: 68e400c820 ℹ️
Status: Passed Duration: 00:48 💡
Started: May 30, 2023 4:34 PM Ended: May 30, 2023 4:35 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking
Copy link
Contributor Author

Failing test passes locally... a problem for another time :)

@allisonking allisonking merged commit 7bef710 into main May 30, 2023
@allisonking allisonking deleted the aking/enable-privacy-experience-flag branch May 30, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

@eastandwestwind eastandwestwind Awaiting requested review from eastandwestwind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @TheAndrewJackson