-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to select different locations in the "Cookie House" sample app #3362
Conversation
Passing run #2153 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
I've got some Cypress tests to update! 😄 But otherwise I think this is looking good. |
OK, updated those tests to make everything line up with @eastandwestwind's updates to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Closes #3277
Code Changes
npm run dev
script to spin up a development databasereact-select
dependency for a nice select component?geolocation=
URL query param (for power users to set that themselves!)?geolocation=
query param to thefides.js?geolocation=
script tag, to force prefetching the geolocationgeolocation
option to match latestfides.js
updatesSteps to Confirm
window.Fides.geolocation
defaults to undefinedwindow.Fides.geolocation
is set to the geolocation data (e.g.US-CA
)Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This adds the ability to "force" a location to the Cookie House sample app, which'll be a killer feature for testing & demoing all our geolocation-specific consent tooling.