-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Endpoints Privacy Experiences and Save Privacy Preferences #3339
Conversation
Passing run #2115 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
… use updated test fides user device id.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 87.09% 87.07% -0.03%
==========================================
Files 313 313
Lines 18988 18997 +9
Branches 2475 2474 -1
==========================================
+ Hits 16537 16541 +4
- Misses 2009 2014 +5
Partials 442 442
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, really clean implementation! is there a test for a uuid that isn't the right format? I didn't see one, but I very well may have missed it in the large diff 😄
# Conflicts: # CHANGELOG.md # tests/ops/api/v1/endpoints/test_privacy_experience_endpoints.py
Good call, @allisonking. None of our previous tests had the UUID in the right format on the backend, they were all "test_id" or similar so I changed all of those and neglected to add the test you mention! |
Closes #3229, #3228
Code Changes
Steps to Confirm
CONFIG.security.public_request_rate_limit
locally to be something like 5/minute and then send GET PrivacyExperience List and PATCH PrivacyPreference endpoints locally in rapid succession to confirm this separate rate limitingPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Make the Privacy Experience List endpoint public and add rate limiting.