Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put global settings for fides.js on privacy center settings #3333

Merged
merged 2 commits into from
May 19, 2023

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented May 18, 2023

Closes #3332

Code Changes

  • Move global settings for fides.js to privacy center env config

Steps to Confirm

  • Update any or all of these env variables:
process.env.FIDES_PRIVACY_CENTER__DEBUG,
process.env.FIDES_PRIVACY_CENTER__IS_OVERLAY_DISABLED,
process.env.FIDES_PRIVACY_CENTER__IS_GEOLOCATION_ENABLED,
process.env.FIDES_PRIVACY_CENTER__GEOLOCATION_API_URL,
process.env.FIDES_PRIVACY_CENTER__PRIVACY_CENTER_URL
Screenshot 2023-05-18 at 7 29 54 PM
  • Confirm the PC homepage still works as expected (sanity check)

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented May 18, 2023

Passing run #2067 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e21c489 into 9a26ca1...
Project: fides Commit: c4399b19e5 ℹ️
Status: Passed Duration: 00:46 💡
Started: May 19, 2023 2:46 PM Ended: May 19, 2023 2:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot works great! so I'll grab the geolocation using parameters provided by settings 👍

I added a commit just to autoformat so that hopefully the tests pass!

@allisonking allisonking merged commit d407775 into main May 19, 2023
@allisonking allisonking deleted the global-pc-settings branch May 19, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put global settings for fides.js on privacy center settings
2 participants