-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3271 data categories for manual connectors #3330
Conversation
Everything looks good. Once the conflict is resolved and the additional test case is added I think it'll be ready 👍 |
Passing run #2086 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
- Coverage 87.07% 87.07% -0.01%
==========================================
Files 313 313
Lines 18968 18970 +2
Branches 2473 2473
==========================================
+ Hits 16517 16518 +1
Misses 2009 2009
- Partials 442 443 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #3270 #3271
Code Changes
CustomSelect
component to only display the labelText
component if a label is providedDSRCustomizationForm
component to include an optionalData Categories
columndata_categories
field toManualWebhookField
modelSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md