Unnest ops API code

[ThomasLaPiana]

Code Changes

• move the fides.api.ops dir up one into fides.api

Steps to Confirm

• tests pass

Pre-Merge Checklist

• All CI Pipelines Succeeded (failures are all expected failures)
• Relevant Follow-Up Issues Created (follow-up plus issue]
• Update CHANGELOG.md

Description Of Changes

In preparation for fully integrating ops/ctl code, this small (but with a large diff 😬 ) iteration unnests the ops code into fides.api

[cypress]

Passing run #2055 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 1a70c8f into 83bada6...
Project: fides	Commit: 82d3b49f5c ℹ️
Status: Passed	Duration: 00:43 💡
Started: May 18, 2023 5:53 AM	Ended: May 18, 2023 5:54 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 97.87% and no project coverage change.

Comparison is base (83bada6) 87.07% compared to head (1a70c8f) 87.07%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3318   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         313      313           
  Lines       18968    18968           
  Branches     2473     2473           
=======================================
  Hits        16517    16517           
  Misses       2009     2009           
  Partials      442      442           

Impacted Files	Coverage Δ
src/fides/api/api/v1/endpoints/utils.py	100.00% <ø> (ø)
src/fides/api/api/v1/scope_registry.py	100.00% <ø> (ø)
src/fides/api/api/v1/urn_registry.py	100.00% <ø> (ø)
src/fides/api/cryptography/cryptographic_util.py	100.00% <ø> (ø)
src/fides/api/cryptography/schemas/jwt.py	100.00% <ø> (ø)
src/fides/api/ctl/view.py	0.00% <0.00%> (ø)
src/fides/api/email_templates/__init__.py	100.00% <ø> (ø)
src/fides/api/email_templates/template_names.py	100.00% <ø> (ø)
src/fides/api/graph/data_type.py	88.81% <ø> (ø)
src/fides/api/oauth/jwt.py	100.00% <ø> (ø)
... and 236 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adamsachs]

this looks good, did some smoke testing on my local server too and things generally looked fine.

only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?

looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

[ThomasLaPiana]

this looks good, did some smoke testing on my local server too and things generally looked fine.

only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?

looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.

To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

[adamsachs]

this looks good, did some smoke testing on my local server too and things generally looked fine.
only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?
looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.

To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

that's good with me! sorry, looks like you've already got some conflicts :/

[ThomasLaPiana]

this looks good, did some smoke testing on my local server too and things generally looked fine.
only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?
looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.
To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

that's good with me! sorry, looks like you've already got some conflicts :/

haha no worries! I knew I wouldn't get away clean this time 😂 after going through the Fides 2.0 merge I think I can handle just about anything in terms of conflicts