-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge privacy declaration components #3254
Conversation
The redux calls had originally been isolated to a parent component to facilitate reuse across redux environments, but we do not need that anymore
94dd6dd
to
0c98c57
Compare
Passing run #1841 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clients/admin-ui/src/features/system/privacy-declarations/PrivacyDeclarationForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that tiny datamap issue! LGTM
🚀
Closes #2976
Code Changes
In other words, hopefully keep all existing functionality as-is, but everyone uses the same component!
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
There's still a good chunk of refactoring these components could go through, but I'll split those into a separate ticket since I wanted to make sure we could get on-par functionality first. Some things would be:
PrivacyDeclarationResponse
instead of the composedPrivacyDeclarationWithId
PrivacyDeclarationWithId
—that was just a stopgap while privacy declarations didn't have IDs on the backendPrivacyDeclarationForm
call the taxonomy data APIs instead of the parent component which then prop drills down. This was useful for reusing a component that had separate redux hooks (back when we had different repos for the datamap-ui and the admin-ui) but is now just a lot of prop drillingif
props down